Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fixes #6403 #6574

Closed
wants to merge 3 commits into from
Closed

Fixes #6403 #6574

wants to merge 3 commits into from

Conversation

samsonasik
Copy link
Contributor

Fixes #6403

@samsonasik samsonasik mentioned this pull request Aug 14, 2014
Closed
@Ocramius Ocramius added this to the 2.4.0 milestone Aug 14, 2014
@Ocramius Ocramius self-assigned this Aug 14, 2014
@samsonasik samsonasik force-pushed the patch.newinstanceargs branch from a995ffb to 7e15b82 Compare September 28, 2014 17:08
@Ocramius
Copy link
Member

Adding the BC break label as the class usage changes slightly. Merging only into 2.4

Ocramius added a commit that referenced this pull request Nov 22, 2014
@Ocramius
#6574 #6403 - removing redundant docblock
2f498e4
Ocramius added a commit that referenced this pull request Nov 22, 2014
@Ocramius
#6574 #6403 - removing redundant docblock
4b5f2a3
Ocramius added a commit that referenced this pull request Nov 22, 2014
@Ocramius
Merge branch 'hotfix/#6574-db-select-paginator-factory-should-use-mut…
0623a8e 
…able-creation-options' into develop

Close #6574
Close #6403
@Ocramius
Copy link
Member

@samsonasik merged into develop at 0623a8e, thanks!

@Ocramius Ocramius closed this Nov 22, 2014
gianarb pushed a commit to zendframework/zend-paginator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6574 zendframework/zendframework#6403 - r…
63f3981 
…emoving redundant docblock
gianarb pushed a commit to zendframework/zend-paginator that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6574 zendframework/zendframework#6403 - r…
332b8cb 
…emoving redundant docblock
gianarb pushed a commit to zendframework/zend-paginator that referenced this pull request May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6574-db-select-pagin…
51939d3 
…ator-factory-should-use-mutable-creation-options' into develop

Close zendframework/zendframework#6574
Close zendframework/zendframework#6403
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
BC Break enhancement Paginator
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Removing $class->newInstanceArgs($this->creationOptions) from Zend\Paginator\Adapter\Service\DbSelectFactory
2 participants
@samsonasik @Ocramius