This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fixed #6324: Redis::setItems: the last item is overwritten #6575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marc-mabe is there any additional work necessary on this, or is it good to merge? Tests pass on Travis-CI after some minor CS fixes (build) |
adamlundrigan
added a commit
to adamlundrigan/zf2
that referenced
this pull request
Nov 15, 2014
|
It's ready to merge |
|
@marc-mabe merged, thanks! |
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…last-item-overwritten-fixes-zendframework/zf2#6324' Close zendframework/zendframework#6575 Close zendframework/zendframework#6324
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…last-item-overwritten-fixes-zendframework/zf2#6324' into develop Close zendframework/zendframework#6575 Close zendframework/zendframework#6324 Forward port zendframework/zendframework#6575 Forward port zendframework/zendframework#6324
boesing
pushed a commit
to laminas/laminas-cache-storage-adapter-test
that referenced
this pull request
May 24, 2020
…last-item-overwritten-fixes-zendframework/zf2#6324' into develop Close zendframework/zendframework#6575 Close zendframework/zendframework#6324 Forward port zendframework/zendframework#6575 Forward port zendframework/zendframework#6324
boesing
pushed a commit
to laminas/laminas-cache-storage-adapter-apc
that referenced
this pull request
May 24, 2020
…last-item-overwritten-fixes-zendframework/zf2#6324' into develop Close zendframework/zendframework#6575 Close zendframework/zendframework#6324 Forward port zendframework/zendframework#6575 Forward port zendframework/zendframework#6324
boesing
pushed a commit
to laminas/laminas-cache-storage-adapter-redis
that referenced
this pull request
Jul 5, 2020
…last-item-overwritten-fixes-zendframework/zf2#6324' into develop Close zendframework/zendframework#6575 Close zendframework/zendframework#6324 Forward port zendframework/zendframework#6575 Forward port zendframework/zendframework#6324
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6324 where the last item value will be overwritten by the previous one in
Redis::setItems().I have updated the common test to catch this issue up on all adapters.
The PR #6347 can be closed.