This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add controller's implemented interfaces to its shared event manager default identifiers #6615
Closed
SwissEngine
wants to merge
4
commits into
zendframework:develop
from
SwissEngine:controllers-identifiers
Closed
Add controller's implemented interfaces to its shared event manager default identifiers #6615
SwissEngine
wants to merge
4
commits into
zendframework:develop
from
SwissEngine:controllers-identifiers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwissEngine
changed the title
Add controller's implemented interfaces to event manager identifiers
Add controller's implemented interfaces to its shared event manager default identifiers
Aug 30, 2014
@SwissEngine can you please rebase this? There's an unrelated commit in it. Additionally, tests required. |
)); | ||
); | ||
|
||
$instanceof = class_implements($this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May just if ($instanceOf = class_implements($this)) {
instead
tca3
force-pushed
the
controllers-identifiers
branch
from
October 11, 2014 10:14
0861e31
to
e63d5e1
Compare
@Ocramius rebased and changed, will write tests today |
namespace ZendTest\Mvc\Controller\TestAsset; | ||
|
||
interface SampleInterface | ||
{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end with
{
}
and a new line at end of file
Related to #6553 |
@SwissEngine this was manually merged into |
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
…greatly depending on interface/class inheritance
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
…oller-event-identifiers' into develop Close #6615
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, from the shared manager, it is not possible to attach a callback to a controller (dispatch event) from an interface id it implements.
I simply added the list of the implemented classes to the identifiers. This adds the possibility to do this:
I am not an expert on the event managers, waiting for some feedback before adding some tests.