This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
add getAdapterInstance() that return adapter instance at Zend\Filter\Encrypt #6758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
| * @return string | ||
| * @throws Exception\RuntimeException | ||
| * @throws Exception\InvalidArgumentException | ||
| * @return Encrypt\EncryptionAlgorithmInterface |
There was a problem hiding this comment.
yes, that's why it go to develop, no ?
There was a problem hiding this comment.
Yes, but breaks have to be avoided where possible
There was a problem hiding this comment.
not sure... , @ezimuel any opinion ?
There was a problem hiding this comment.
It is trivial to change into getAdapter and getAdapterInstance, and I think it's an acceptable tradeoff for now.
There was a problem hiding this comment.
@Ocramius ok, I will change it.
samsonasik
changed the title
|
@Ocramius done ;). I've changed getAdapter() and added getAdapterInstance(), and change PR title, please let me know if there is I missed ;) |
samsonasik
force-pushed
the
imp.todo.adapter
branch
from
65a8897 to
97f065c
Compare
and add getAdapterName() to get name of adapter
samsonasik
force-pushed
the
imp.todo.adapter
branch
from
97f065c to
83ef554
Compare
|
@Ocramius merge-able now ? ;) |
weierophinney
added a commit
that referenced
this pull request
Feb 24, 2015
add getAdapterInstance() that return adapter instance at Zend\Filter\Encrypt
weierophinney
added a commit
that referenced
this pull request
Feb 24, 2015
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…mp.todo.adapter add getAdapterInstance() that return adapter instance at Zend\Filter\Encrypt
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add
getAdapterName()to get name of adapter same asZend\Filter\Compressclass to make it consistent.