Fixes #6768 : boolean false values at priority list should be valid

[samsonasik]

Fixes #6768

[bgaillard]

Hi, this is a critical issue, it prevents us to upgrade from zf 2.2 to zf 2.3.

As their are unit tests is it possible to quickly integrate this fix in the next minor version of the framework ?

Thanks.

[turrsis]

enough return (current($this->items) !== false);
protected $currentNode = false; is superfluous

[samsonasik]

Done ;). thank you ;)

[turrsis]

please, add $this->list->insert('foo', null, null); here

[samsonasik]

Done ;)

[turrsis]

was meant this:

        $this->list->insert('null', null, null);
        $this->list->insert('false', false, null);
        $this->list->insert('string', 'test', 1);
        $this->list->insert('true', true, -1);

        $orders1 = array();
        $orders2 = array();

        foreach ($this->list as $key => $value) {
            $orders1[$this->list->key()] = $this->list->current();
            $orders2[$key] = $value;
        }
        $this->assertEquals($orders1, $orders2);
        $this->assertEquals(
            array(
                'null'   => null,
                'false'  => false,
                'string' => 'test',
                'true'   => true,
            ),
            $orders2
        );

[turrsis]

@Ocramius this is realy critical bug

[Ocramius]

Merged, thanks!

master: 2add207
develop: c2e67b8

[samsonasik]

@Ocramius test case on develop failure, it seems some commits in master in valid() not merged to develop, no ?

[Ocramius]

@samsonasik thanks for noticing. This is indeed a merge conflict SNAFU. Will fix right now.

[Ocramius]

@samsonasik interestingly, Stdlib tests pass, whereas the Db tests fail. Maybe the test case doesn't cover everything accurately? Can you look into it?

[samsonasik]

@Ocramius latest master :
return current($this->items) !== false;
latest develop :
return $this->current() !== false;

It seems I need to rollback to use "hold" currentNode like this : samsonasik@e9812a0 ?

[Ocramius]

@samsonasik besides that, the unit test in ZendTest\Stdlib doesn't expose the failure, that's why I didn't notice the regression.

[turrsis]

@samsonasik I try to use all your tests without $currentNode and with return current($this->items) !== false; - all was ok

[turrsis]

@Ocramius @samsonasik I don't see https://github.com/zendframework/zf2/pull/6773/files#diff-a467cf942714106b418ab71c5cad4e36R236, I'm wrong?

[samsonasik]

@turrsis should already been updated at #6904

[turrsis]

@Ocramius @samsonasik sorry - all ok