This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
remove PHP_VERSION_ID check before 50323 #6785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param bool $value | ||
| * @return Bcrypt | ||
| */ | ||
| public function setBackwardCompatibility($value) |
There was a problem hiding this comment.
Removing the methods is quite a BC break. Deprecate them and make them no-op (always return the same value, do nothing) instead
samsonasik
force-pushed
the
compat-php5323
branch
from
ba02f2e to
52080a5
Compare
|
@Ocramius done ;). I've re-add the setBackwardCompatibility\getBacwardCompatibility functions. |
samsonasik
force-pushed
the
compat-php5323
branch
from
8d0c16b to
7ee14a3
Compare
| @@ -896,14 +896,6 @@ protected static function isSubclassOf($className, $type) | |||
| if (is_subclass_of($className, $type)) { | |||
There was a problem hiding this comment.
return is_subclass_of($className, $type);
samsonasik
force-pushed
the
compat-php5323
branch
from
7ee14a3 to
59f1f8c
Compare
| @@ -208,13 +207,6 @@ protected static function isSubclassOf($className, $type) | |||
| if (is_subclass_of($className, $type)) { | |||
There was a problem hiding this comment.
Another candidate for returning is_subclass_of() directly.
Ocramius
added a commit
that referenced
this pull request
Nov 27, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 27, 2014
…sage See bug https://bugs.php.net/bug.php?id=53727 See bug #1807 Deprecating protected static polyfill method `isSubclassOf`
Ocramius
added a commit
that referenced
this pull request
Nov 27, 2014
…sage See bug https://bugs.php.net/bug.php?id=53727 See bug #1807 Deprecating protected static polyfill method `isSubclassOf`
Ocramius
added a commit
that referenced
this pull request
Nov 27, 2014
…sage See bug https://bugs.php.net/bug.php?id=53727 See bug #1807 Deprecating protected static polyfill method `isSubclassOf`
Ocramius
added a commit
that referenced
this pull request
Nov 27, 2014
…sage See bug https://bugs.php.net/bug.php?id=53727 See bug #1807 Deprecating protected static polyfill method `isSubclassOf`
Ocramius
added a commit
that referenced
this pull request
Nov 27, 2014
…sage See bug https://bugs.php.net/bug.php?id=53727 See bug #1807 Deprecating protected static polyfill method `isSubclassOf`
|
@samsonasik merged manually, thanks! |
gianarb
pushed a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…f protected static method usage See bug https://bugs.php.net/bug.php?id=53727 See bug zendframework/zendframework#1807 Deprecating protected static polyfill method `isSubclassOf`
gianarb
pushed a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' Close zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' into develop Close zendframework/zendframework#6785 Forward port zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-math
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' Close zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-math
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' into develop Close zendframework/zendframework#6785 Forward port zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
…f protected static method usage See bug https://bugs.php.net/bug.php?id=53727 See bug zendframework/zendframework#1807 Deprecating protected static polyfill method `isSubclassOf`
gianarb
pushed a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' Close zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' into develop Close zendframework/zendframework#6785 Forward port zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-crypt
that referenced
this pull request
May 15, 2015
…ckwardCompatibility()`
gianarb
pushed a commit
to zendframework/zend-crypt
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' Close zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-crypt
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' into develop Close zendframework/zendframework#6785 Forward port zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
…f protected static method usage See bug https://bugs.php.net/bug.php?id=53727 See bug zendframework/zendframework#1807 Deprecating protected static polyfill method `isSubclassOf`
gianarb
pushed a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' Close zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' into develop Close zendframework/zendframework#6785 Forward port zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
…f protected static method usage See bug https://bugs.php.net/bug.php?id=53727 See bug zendframework/zendframework#1807 Deprecating protected static polyfill method `isSubclassOf`
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' Close zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' into develop Close zendframework/zendframework#6785 Forward port zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' Close zendframework/zendframework#6785
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…checks-for-incompatible-versions' into develop Close zendframework/zendframework#6785 Forward port zendframework/zendframework#6785
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since our minimum php version is 5.3.23