This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Corrects firstItemCount for empty result sets #6809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's a BC break. |
|
@samsonasik can you clarify on why it would be a BC break? |
|
because old behaviour that show "page 1" when the count data is < item per page. the old application that uses it show the pagination with page that only 1, with the link is disabled. so, changing it should be merged to develop imo. |
|
@davidomelettes manually merged into |
gianarb
pushed a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
…dding missing `@group` annotations for newly introduced test cases
gianarb
pushed a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
…void multiple internal calls to methods when values are already cached in `$pages`
gianarb
pushed a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
…endframework#6809-empty-zend-paginator-first-page-starts-with-1' into develop Close zendframework/zendframework#6808 Close zendframework/zendframework#6809
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #6808