This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Set user and password in Http class #6886
Closed
SenseException
wants to merge
4
commits into
zendframework:master
from
SenseException:http-user-data
Closed
Set user and password in Http class #6886
SenseException
wants to merge
4
commits into
zendframework:master
from
SenseException:http-user-data
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return $this->password; | ||
} | ||
|
||
$this->parseUserInfo(); | ||
return $this->password; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got trailing spaces in this line.
I found a few more and removed the spaces. |
Ocramius
added a commit
that referenced
this pull request
Nov 18, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 18, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 18, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 18, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 18, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 18, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 18, 2014
@SenseException I've manually rebased and merged this PR into Thanks! |
gianarb
pushed a commit
to zendframework/zend-uri
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-uri
that referenced
this pull request
May 15, 2015
…y introduced tests
gianarb
pushed a commit
to zendframework/zend-uri
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-uri
that referenced
this pull request
May 15, 2015
…d by copy/paste)
gianarb
pushed a commit
to zendframework/zend-uri
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-uri
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-uri
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-uri
that referenced
this pull request
May 15, 2015
…password-support' into develop Close zendframework/zendframework#6886
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zend\Uri\Http is extending Zend\Uri\Uri and therefore is also having the getter and setter method for the user info from an URI. Also, the Http class has separate setter and getter for the user and password.
At the moment, when the user info is set, Http automatically is setting the properties for user and password.
But when values are set with setUser and setPassword, the user info is not updated. The following test fails:
It is a strange behaviour that setting the user info is also setting the user and password in Http class, but the setter of user and password doesn't affect the user info value.
I created this pull request with a fix of this behaviour and add some more unittests for Http.