This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Throw an ServiceNotFoundException in AbstractPluginManager when the invokable does not exist. #6902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error is not related to this PR |
|
@macnibblet thanks! Merged: |
gianarb
pushed a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…auto-invokables-should-reject-non-existing-classes' Close zendframework/zendframework#6902
gianarb
pushed a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…auto-invokables-should-reject-non-existing-classes' into develop Close zendframework/zendframework#6902 Forward port zendframework/zendframework#6902
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimic the same behaviour in the
AbstractPluginManager::createFromInvokableas in theServiceManager::createFromInvokable.This could have been resolved by adding a check in the
ServiceManager::setInvokablebut that could potentially break a lot of peoples modules when they register optional invokables for extensions that are not loaded.