This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Ability to replace key in ArrayUtils::merge #6903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| namespace Zend\Stdlib\ArrayUtils; | ||
|
|
||
| class MergeReplaceKey |
There was a problem hiding this comment.
I would also suggest making this final
There was a problem hiding this comment.
Why? By final we close the doors to extending logic in this class. I see use case where someone want to add filter to this.
There was a problem hiding this comment.
Yes, this is indeed what final is for. This object is just a thin data wrapper, and I don't see any advantage in extending it, not even in cases where you want to fetch data from, say, a DB connection.
If you think there is a use-case for extension, then I suggest interfacing it instead, and making this concrete implementation final
There was a problem hiding this comment.
The interface makes sense
Ocramius
added a commit
that referenced
this pull request
Dec 6, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 6, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 6, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 6, 2014
|
@snapshotpl manually merged, thank you!
|
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…ReplaceKeyInterface`
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…removing inherited docblock documentation
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…ly introduced tests
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…g-keys-in-array-utils' into develop Close zendframework/zendframework#6903
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's related with remove key #6899 @Ocramius