allow header field value of "0" #6907
Conversation
'0' is a valid value for headers, such as content-length
| if ($value && strpos($key, 'HTTP_') === 0) { | ||
| if (strpos($key, 'HTTP_COOKIE') === 0) { | ||
| // Cookies are handled using the $_COOKIE superglobal | ||
| if ((is_array($value) && $value) || (strlen($value))) |
There was a problem hiding this comment.
Why are you allowing arrays if the issue is about the value 0? Allowing arrays seems to be the source of lots of Travis errors.
There was a problem hiding this comment.
My first commit failed because arrays are apparently a valid type for $value, but I guess I didn't quite fix it with this one
|
Not sure how to figure out why Travis failed. I'd like to learn how to contribute properly, let me know what else I can do |
|
@shinymayhem I will restart the build: the travis setup was broken by me some days ago, sorry about that! |
|
@Ocramius Travis was working fine with this PR. When I posted my comment I saw normal results and failing testcases related to this issue on Travis. When I look now, I see Travis results are broken. Looks to me it is Travis itself that is broken and not the Travis setup? |
'0' is a valid value for headers, such as content-length
|
@Ocramius did I do the rebase correctly? |
|
@shinymayhem I'll do the rebase myself, there is still a dangling commit. |
…ying loop logic, avoiding eager `is_array()` calls
…headers' into develop Close zendframework/zendframework#6907 Forward port zendframework/zendframework#6907
'0' is a valid value for headers, such as content-length and custom headers