Fix: Remove unused parameter and class property #6914
Conversation
| @@ -54,8 +54,6 @@ public function __construct($connection, Statement $statementPrototype = null, R | |||
| $connection = new Connection($connection); | |||
| } | |||
|
|
|||
| $options = array_intersect_key(array_merge($this->options, $options), $this->options); | |||
There was a problem hiding this comment.
I'm thinking it's supposed to be
$this->options = array_intersect_key(array_merge($this->options, $options), $this->options);There was a problem hiding this comment.
Shall I update?
localheinz
force-pushed
the
bugfix/unused-local-variable
branch
from
d53b936 to
4009c06
Compare
localheinz
changed the title
| @@ -54,7 +54,7 @@ public function __construct($connection, Statement $statementPrototype = null, R | |||
| $connection = new Connection($connection); | |||
| } | |||
|
|
|||
| $options = array_intersect_key(array_merge($this->options, $options), $this->options); | |||
| $this->options = array_intersect_key(array_merge($this->options, $options), $this->options); | |||
There was a problem hiding this comment.
Still looks like it's fixing something. What was broken before this change, @macnibblet?
There was a problem hiding this comment.
After reviewing the code closely my recommendation would be to remove $options from the constructor and $this->options from the class since they are not actually used.
There was a problem hiding this comment.
Since injecting $options hasn't had any effect: 👍
localheinz
force-pushed
the
bugfix/unused-local-variable
branch
from
4009c06 to
8a44be4
Compare
localheinz
changed the title
localheinz
force-pushed
the
bugfix/unused-local-variable
branch
from
8a44be4 to
561f927
Compare
|
|
||
| ); | ||
|
|
||
| /** | ||
| * @param array|Connection|\oci8 $connection |
There was a problem hiding this comment.
Can you change oci8 to Oci8
There was a problem hiding this comment.
If that's what it should be, this needs a fix in more than one file.
There was a problem hiding this comment.
No nevermind, that was a misstake.
Injecting
$optionshas no effect and class property$optionsis never used.