This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Hotfix/6278 #6927
Closed
Hotfix/6278 #6927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -175,6 +175,37 @@ public function testConstructionWithOptions($input, $expected) | |||
| $this->assertEquals($expected, $validator->isValid($input)); | |||
| } | |||
|
|
|||
| public static function jcbValues() | |||
There was a problem hiding this comment.
static is not required here, and will probably cause an issue/notice in the future.
|
@macnibblet @Ocramius Ok, i have removed the 'static' keyword :) |
|
@MadCat34 the cache failure is unrelated, and it's mainly because of a risky test. |
|
@Ocramius Yes, i know it was unrelated :-) |
Ocramius
added a commit
that referenced
this pull request
Nov 27, 2014
…equest that introduced the test
Ocramius
added a commit
that referenced
this pull request
Nov 27, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 27, 2014
|
@Ocramius Ok. I'll be careful next time :-) And i'll add docblock too :-) Thanks |
|
@MadCat34 no problem at all: rebases are always messy and complicated ;-) |
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…dding missing `@group` docblock referencing the pull request that introduced the test
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…dding missing docblock
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…dding missing docblock parameters, minor cs fixes
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…endframework#6278-jcb-credit-card-validator-allowed-ranges-update' Close zendframework/zendframework#6927 Close zendframework/zendframework#6278
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…endframework#6278-jcb-credit-card-validator-allowed-ranges-update' into develop Close zendframework/zendframework#6927 Close zendframework/zendframework#6278 Forward port zendframework/zendframework#6927 Forward port zendframework/zendframework#6278
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6278