This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Remove unused code #6969
Closed
Remove unused code #6969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks like the failed test is an unstable one :-(. An other build in an other branch with the same changes did pass! |
|
@jaapio yes, the filesystem integration tests got much more unreliable lately, mainly because travis got much slower there :-( |
| @@ -1049,8 +1049,6 @@ protected function drawBarcode() | |||
| { | |||
| $barcodeTable = $this->prepareBarcode(); | |||
|
|
|||
| $this->preDrawBarcode(); | |||
There was a problem hiding this comment.
This should probably be re-included, as the preDrawBarcode() may be used in subclasses (that may be outside the framework)
|
Marking for 2.4: won't merge in `master due to the risk of regressions |
|
In that case, should this one go to the development branch? |
|
You can keep it as-is: it's just a question of merging, up to me :-) |
added 3 commits
December 8, 2014 08:35
Ocramius
added a commit
that referenced
this pull request
Dec 8, 2014
|
Pulled locally, rebased onto |
weierophinney
pushed a commit
to zendframework/zend-authentication
that referenced
this pull request
May 14, 2015
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
gianarb
pushed a commit
to zendframework/zend-config
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-crypt
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-json
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An other set of fixes for #5860. In this pr I reviewed all unused code Scrutinizer issues. The most obvious issues are fixed in this pr.