Fixing prepended NotEmpty validator

[gabrielsch]

When using InputFilter standalone (without dev dependencies), this is broken because this line calls ValidatorPluginManager, and this class inherits AbstractPluginManager, that is suggested at composer.json, not required.

Then the following error is thrown:
PHP Fatal error: Class 'Zend\ServiceManager\AbstractPluginManager' not found in /zf2/library/Zend/Validator/ValidatorPluginManager.php on line 16

I just changed the prependByName method (that uses PluginManager) to prependValidator, instantiating the validator by hand.

[danizord]

👍

[fabiocarneiro]

👍

[Ocramius]

While I agree with the change, this is also a BC break, since your validator will now come with untranslated messages, and overriding the default 'NotEmpty' will become problematic without subclassing the 'Input' class.

[gabrielsch]

@Ocramius but this would not be a bug? I can't use the InputFilter component without ServiceManager, it's a big problem IMO, or maybe we should put zend-servicemanager as a required dep.

[Ocramius]

@gabrielsch I'd rather fix the problem via a class_exists() somewhere instead.

[Ocramius]

To be precise, prependByName should work with or without ServiceManager IMO

[weierophinney]

Suggestion: test to see if class_exists('Zend\ServiceManager\AbstractPluginManager'), and use prependByName() if it's present, and prependValidator() if not.

[gabrielsch]

ok @weierophinney, I'll finish that soon

[gabrielsch]

done @weierophinney , sorry for the delay 😄

[weierophinney]

Merged to develop for release with 2.4.