Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

.php_cs - sort fixers #7011

Merged
merged 1 commit into from
Dec 11, 2014
Merged

Conversation

keradus
Copy link
Contributor

@keradus keradus commented Dec 11, 2014

No description provided.

@@ -29,19 +29,19 @@ $config = Symfony\CS\Config\Config::create();
$config->level(null);
$config->fixers(
array(
'indentation',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the diff minimal? :|

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid that I do not understand what do you mean by that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nvm, just saw that you only sorted them. That's fine as long as there were no functional changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. just want the list to be clean when adding new items in it ;)
For next PRs to be minimal ;)

Should I do anything else to remove that awaiting author updates label ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that

@localheinz
Copy link
Member

👍

Ocramius added a commit that referenced this pull request Dec 11, 2014
@Ocramius Ocramius merged commit 40aa847 into zendframework:develop Dec 11, 2014
@Ocramius
Copy link
Member

@keradus merged, thanks!

@keradus keradus deleted the php_cs-sort_fixers branch December 11, 2014 18:18
weierophinney pushed a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants