This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Found bugs in Zend\Db\Sql\Ddl classes and tests
#7015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable typo in Zend\Db\Sql\Ddl\Index\Index. Property name was `$name` but `$namee` was referenced
The value of Boolean::$type was changed from `TINYINT` to `BOOLEAN` in a [commit](The e287ebf) made by @SlayerBirden. It appears the tests were not changed to account for the new value.
chadicus
changed the title
Zend\Db\Sql\Ddl classes and tests
|
ping @ralphschindler |
|
I see no problems for these. As a note, boolean in practice is not widely used, also, it did not come to be part of the SQL standard until SQL99; so, not sure what you want to do about that part. |
Ocramius
added a commit
that referenced
this pull request
Dec 16, 2014
Found bugs in `Zend\Db\Sql\Ddl` classes and tests
|
@chadicus merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some bugs in the
Zend\Db\Sql\Ddlclasses and tests