Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Cache: fixed some minor documentation issues #7033

Closed
wants to merge 1 commit into from
Closed

Cache: fixed some minor documentation issues #7033

wants to merge 1 commit into from

Conversation

marc-mabe
Copy link
Member

Now within plugin IgnoreUserAbort the method getStorage() will be used instead of getTarget(). The methods are aliases but getStorage() is described to return an StorageInterface but getTarget() is inherited by the default event and can return nearly everything.

@Ocramius Ocramius added this to the 2.3.4 milestone Dec 13, 2014
@Ocramius Ocramius self-assigned this Dec 13, 2014
@Ocramius Ocramius closed this in 94d4cdb Dec 16, 2014
Ocramius added a commit that referenced this pull request Dec 16, 2014
@Ocramius
Copy link
Member

@marc-mabe merged, thx!

master: 94d4cdb
develop: 1bf2fd5

@marc-mabe
Copy link
Member Author

@Ocramius Thanks for merge. It looks like you merge with rebase.

@Ocramius
Copy link
Member

@marc-mabe yes, had to because of merge conflicts.

@marc-mabe
Copy link
Member Author

@Ocramius Sorry but I don't think that's the right way to do because now you lost all author information and linked PR information. Why you couldn't resolve the conflicts within a merge or ask for an author rebase?

This PR isn't a big deal but future PRs could be ;)

@Ocramius
Copy link
Member

@marc-mabe no authorship lost: all your commits are in the merged branch, just with different hashes though, that's why github doesn't consider the pr "merged", but just closed

gianarb pushed a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
boesing pushed a commit to laminas/laminas-cache-storage-adapter-apc that referenced this pull request May 24, 2020
boesing pushed a commit to laminas/laminas-cache-storage-adapter-dba that referenced this pull request Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants