[Db\Sql\Platform\Mysql\Ddl] override getSqlString() is wrong

[turrsis]

No description provided.

[Ocramius]

@turrsis needs a test case that validates the "wrong" in the issue description :-)

[turrsis]

1. This functional is already exist in parent class (see AbstractSql::getSqlString() then AbstractSql::buildSqlString()).
2. Below code is dublicate AbstractSql::localizeVariables()

    // localize variables
    foreach (get_object_vars($this->subject) as $name => $value) {
    $this->{$name} = $value;

1. For override should inherit AbstractSql::buildSqlString
2. This functions was removed in Db\Sql - cleaning code duplicates #5701

[Ocramius]

Ah, I see: wrong conflict resolution. Merging, thanks!

[Martin-P]

Travis shows this change is breaking tests, so either tests need to be updated or this code was not wrong after all.

[turrsis]

@Martin-P where i can see this Travis log?

[Martin-P]

You can click the red cross next to your commit. This page shows the errors for the different PHP versions: https://travis-ci.org/zendframework/zf2/builds/44094896

[Ocramius]

@Martin-P the tests were broken upfront by a previous Zend\Db rebase+merge.

Most probably https://travis-ci.org/zendframework/zf2/builds/43678177 ( #6556 )