This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Cache: better fix for #5860 introduced in #5863 #7039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -597,7 +597,7 @@ public function setObjectKey($objectKey) | |||
| */ | |||
| public function getObjectKey() | |||
| { | |||
| if (!$this->objectKey) { | |||
| if ($this->objectKey === null) { | |||
There was a problem hiding this comment.
There is a logic change here: is there a test differentiating false and null?
There was a problem hiding this comment.
The setter setObjectKey allows only string and NULL but thinking more of it you are right as of before an empty string or "0" was handled the same as NULL. So I think "0" should be a valid key but an empty string should not be allowed by setter.
-> I'll update the PR and add a test case for it
…rks as expected
|
@Ocramius test is available now |
|
Thanks @marc-mabe! |
|
Merged, thanks @marc-mabe! |
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…ernOptions::setObjectKey works as expected
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…tfix/5860_5863 Cache: better fix for zendframework/zendframework#5860 introduced in zendframework/zendframework#5863
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache: better fix for #5860 introduced in #5863