Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Travis: running more tests for cache component #7067

Closed
wants to merge 1 commit into from
Closed

Travis: running more tests for cache component #7067

wants to merge 1 commit into from

Conversation

marc-mabe
Copy link
Member

  • enabled Apc storage adapter tests using last available apcu extension
  • enabled Memcache storage adapter tests using pre-installed but not enabled memcache extension
  • enabled Memcached storage adapter tests using pre-installed but not enabled memcached extension
    • start memcached on before_script
  • enabled Redis storage adapter tests using pre-installed but not enabled redis extension
    • start redis-server on before_script
  • enabled all other storage adapter tests even if they are not available.
    • the tests will be skipped automatically but this enables testing of the availability check + expected exception
  • removed constant for SQLite because the is no Sqlite storage adapter yet

There are some tests failing currently but these should be solved by #7065 and #7043

@Ocramius ping

@Ocramius
Copy link
Member

While I like the idea of testing new adapters, how much does this affect build times?

@marc-mabe
Copy link
Member Author

see https://travis-ci.org/marc-mabe/zf2/builds/44806387

The most additional time is for running the additional tests but that will be in parallel and should be negligible. memcached and redis is already installed - so only needs to be started.
So the most performance lost will be installing apcu as of this requires downloading + compiling the extension (~14s).

@weierophinney weierophinney added this to the 2.4.0 milestone Feb 19, 2015
@@ -71,7 +71,6 @@ defined('TESTS_ZEND_BARCODE_PDF_SUPPORT') || define('TESTS_ZEND_BARCODE_PDF_SUPP
* Zend\Cache\Storage\Adapter
*/
defined('TESTS_ZEND_CACHE_APC_ENABLED') || define('TESTS_ZEND_CACHE_APC_ENABLED', false);
defined('TESTS_ZEND_CACHE_SQLITE_ENABLED') || define('TESTS_ZEND_CACHE_SQLITE_ENABLED', false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no sqlite adapter - this is a relict of ZF1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay -- thanks for the clarification!

weierophinney added a commit that referenced this pull request Feb 25, 2015
Travis: running more tests for cache component

Conflicts:
	.travis.yml
weierophinney added a commit that referenced this pull request Feb 25, 2015
@weierophinney
Copy link
Member

Merged to develop for release with 2.4.

weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015
…avis/cache

Travis: running more tests for cache component

Conflicts:
	.travis.yml
weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants