This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Hotfix/encrypt numbers #7083
Closed
Hotfix/encrypt numbers #7083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@bacinsky thanks for changing the PR! |
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…g-numbers' into develop Close zendframework/zendframework#7083
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR https://github.com/zendframework/zf2/pull/5436/files#diff-acc52fa0c89428ade03c42a52bd93c19 introduced a
BC breakbug to the Filter\Encryptand Filter\Decrypt. Before was allowed to encrypt/decryptintegersnumbers, after that PR it's restricted to strings only.https://github.com/zendframework/zf2/blob/4b496e98fcb2a40165a738459a17fb885474d717/library/Zend/Filter/Encrypt.php#L126
https://github.com/zendframework/zf2/blob/4b496e98fcb2a40165a738459a17fb885474d717/library/Zend/Filter/Decrypt.php#L27And I can't mention that silently returning a value when that condition isn't met is nasty, debugging that was annoying.