This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Added trailing comma for multiline arrays #7120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! |
|
Seems like there are more failing related tests |
|
I have some troubles running the tests currently. I found just one issue with the |
|
Ok, wait! Tests are running now again. Will fix them... |
|
Ok, I fixed some other tests. All |
weierophinney
added a commit
that referenced
this pull request
Feb 24, 2015
…y-comma Added trailing comma for multiline arrays
weierophinney
added a commit
that referenced
this pull request
Feb 24, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little fix makes sure that a trailing comma is added after the last item of an array created by
Zend\Code\Generator\ValueGeneratorwhen using the multiple line mode.This trailing comma is suggested by the Coding Standards:
https://zf2-docs.readthedocs.org/en/latest/ref/coding.standard.html#associative-arrays