Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Request from string #7137

Merged
merged 3 commits into from
Jan 19, 2015
Merged

Request from string #7137

merged 3 commits into from
Jan 19, 2015

Conversation

mathiasverraes
Copy link
Contributor

<?php
$request = \Zend\Http\Request::fromString(
    "GET /?foo=bar HTTP/1.1\r\n\r\n"
);

var_dump($request->getQuery()->get('foo'));
// Expected "bar", got null

@mathiasverraes
Copy link
Contributor Author

I've no idea why travis fails :-(

@anthonysterling
Copy link

It looks like Zend\Http\Request::setUri delegates the parsing of the query string to Zend/Uri/Uri.

I suspect it's getting passed /?foo=bar and not ?foo=bar so this pattern never matches.

Maybe.

@mathiasverraes
Copy link
Contributor Author

Did you find a place in the travis builds that fails?

@texdc
Copy link
Contributor

texdc commented Jan 19, 2015

Not sure, but it I'd guess that there's an issue with Travis, not the code or build.

@Ocramius
Copy link
Member

I'll check the CS fixes locally: we handled this in develop, but not in master, so it's indeed a bit annoying to not be able to see the failures.

@Ocramius Ocramius self-assigned this Jan 19, 2015
@Ocramius Ocramius added this to the 2.3.5 milestone Jan 19, 2015
Ocramius added a commit that referenced this pull request Jan 19, 2015
Ocramius added a commit that referenced this pull request Jan 19, 2015
…-string-fix' into develop

Close #7137
Close #7005
Forward port #7137
Forward port #7005
@Ocramius Ocramius merged commit f5755f0 into zendframework:master Jan 19, 2015
Ocramius added a commit that referenced this pull request Jan 19, 2015
@Ocramius
Copy link
Member

Merged, thanks @mathiasverraes!

master: 7e704a7
develop: bef1fc1

@mathiasverraes
Copy link
Contributor Author

YW, thanks for getting this in fast :-)

gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants