This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Request from string #7137
Merged
Ocramius
merged 3 commits into
zendframework:master
from
mathiasverraes:request-from-string
Jan 19, 2015
Merged
Request from string #7137
Ocramius
merged 3 commits into
zendframework:master
from
mathiasverraes:request-from-string
Jan 19, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mathiasverraes
commented
Jan 19, 2015
I've no idea why travis fails :-( |
It looks like Zend\Http\Request::setUri delegates the parsing of the query string to Zend/Uri/Uri. I suspect it's getting passed Maybe. |
Did you find a place in the travis builds that fails? |
Not sure, but it I'd guess that there's an issue with Travis, not the code or build. |
I'll check the CS fixes locally: we handled this in |
Ocramius
added a commit
that referenced
this pull request
Jan 19, 2015
Merged, thanks @mathiasverraes! |
YW, thanks for getting this in fast :-) |
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…S fix (space between `if` and `(`)
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…endframework#7005-phpenvironment-request-ignores-query-string-fix' Close zendframework/zendframework#7137 Close zendframework/zendframework#7005
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…endframework#7005-phpenvironment-request-ignores-query-string-fix' into develop Close zendframework/zendframework#7137 Close zendframework/zendframework#7005 Forward port zendframework/zendframework#7137 Forward port zendframework/zendframework#7005
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.