Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Estonian IDN definition & fixed binary code for HOST_DNS_OR_IPV4_OR_IPV6_OR_REGNAME #7150

Closed
wants to merge 5 commits into from

Conversation

netcreatoreu
Copy link

Before this changed we cannot properly check URL like:

@Ocramius
Copy link
Member

@netcreatoreu can you add relevant example data to test fixtures?

@netcreatoreu
Copy link
Author

@Ocramius can be as a comment?

$url = 'http://plekitööd.ee/';
$uri = new Zend\Uri\Http($url);
var_dump($uri->isValid());

This code responsed FALSE in ZF 2.3.4, but should be TRUE.

@Ocramius
Copy link
Member

@netcreatoreu yes, what I'm asking is for a domain such as that to be introduced in the existing test suite. Look at the existing tests and create an example .ee in there ;-)

@netcreatoreu
Copy link
Author

@Ocramius ok, test added. Also updated a set of characters for Estonian IDN (source : https://www.iana.org/domains/idn-tables/tables/pl_et-pl_1.0.html )

@netcreatoreu
Copy link
Author

@Ocramius This is not "our" failed ;-)

There was 1 failure:

1) ZendTest\Cache\Storage\Adapter\MemoryTest::testClearExpired

Failed asserting that false is true.

/home/travis/build/zendframework/zf2/tests/ZendTest/Cache/Storage/Adapter/CommonAdapterTest.php:1048

FAILURES!

Tests: 1479, Assertions: 2200, Failures: 1, Skipped: 1099.

@Ocramius
Copy link
Member

Restarted the failed worker

Ocramius added a commit that referenced this pull request Feb 2, 2015
@Ocramius Ocramius closed this in 1225ce0 Feb 2, 2015
@Ocramius
Copy link
Member

Ocramius commented Feb 2, 2015

Merged, thanks @netcreatoreu!

master: 1225ce0
develop: 7cd9524

gianarb pushed a commit to zendframework/zend-uri that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-uri that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants