This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Estonian IDN definition & fixed binary code for HOST_DNS_OR_IPV4_OR_IPV6_OR_REGNAME #7150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tant (should be 11011, not 10011)
@netcreatoreu can you add relevant example data to test fixtures? |
@Ocramius can be as a comment?
This code responsed FALSE in ZF 2.3.4, but should be TRUE. |
@netcreatoreu yes, what I'm asking is for a domain such as that to be introduced in the existing test suite. Look at the existing tests and create an example |
@Ocramius ok, test added. Also updated a set of characters for Estonian IDN (source : https://www.iana.org/domains/idn-tables/tables/pl_et-pl_1.0.html ) |
@Ocramius This is not "our" failed ;-)
|
Restarted the failed worker |
Merged, thanks @netcreatoreu! |
gianarb
pushed a commit
to zendframework/zend-uri
that referenced
this pull request
May 15, 2015
…d-fixed-binary-code-for-host-dns-regname' Close zendframework/zendframework#7150
gianarb
pushed a commit
to zendframework/zend-uri
that referenced
this pull request
May 15, 2015
…d-fixed-binary-code-for-host-dns-regname' into develop Close zendframework/zendframework#7150 Forward port zendframework/zendframework#7150
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…d-fixed-binary-code-for-host-dns-regname' Close zendframework/zendframework#7150
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…d-fixed-binary-code-for-host-dns-regname' into develop Close zendframework/zendframework#7150 Forward port zendframework/zendframework#7150
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this changed we cannot properly check URL like:
using \Zend\Uri\Http