Use getEncoding() instead of accessing options array directly

[Martin-P]

Fix for issue #7147. Both Zend\Filter\StringToLower and Zend\Filter\StringToUpper extend Zend\Filter\AbstractUnicode.

No new tests, but that is because I don't see a way to test this change. If anyone got suggestions on how to test it, I will add the tests.

[samsonasik]

no yoda condition for consistencies

[Martin-P]

There is not really a consistency when I do a search in my IDE:

• Found 403 matches of !== null in 205 files
• Found 265 matches of null !== in 129 files

There are even PR's where conditions are being changed to yoda conditions. To mention a few: #3520, #3521, #6750.

[samsonasik]

the #3521 and #3520 , the yoda condition is not accepted. anyway, the current purpose of this pr is changing $this->options['encoding'] to $this->getEncoding(), so changing right to left is a cosmetic imo

[Martin-P]

The yoda condition is cosmetic indeed, but so is PSR2 😉 Personally I prefer yoda conditions, because I think defensive programming is good practice.

[Ocramius]

@Martin-P this requires testing, IMO. Mocking the getEncoding method is also "meh", but required for the test to work :-\

[Martin-P]

How can I mock the method of the same class? This does not work:

public function testFilterUsesGetEncoding()
{
    $filterMock = $this->getMock('StringToLowerFilter');
    $filterMock->expects($this->once())
               ->method('getEncoding')
               ->with();
    $filterMock->filter('foo');
}

Fatal error: Call to undefined method Mock_StringToLowerFilter_0ae23a04::filter()

Adding the filter() method to the mocked object does not help either, because then getEncoding() is never called.

[Ocramius]

@Martin-P add $this->getMock('StringToLowerFilter', array('getEncoding')). The class of the mock must be the FQCN.

[Ocramius]

Note that in strings you always deal with an absolute namespace, therefore the leading \ is not needed and should be avoided.

[Martin-P]

Ah, okay, I have removed them.

[weierophinney]

Merged to develop for release with 2.4.