-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Conversation
bf1ae2a
to
4572e0e
Compare
@@ -37,12 +38,14 @@ $config->fixers( | |||
'function_call_space', | |||
'function_declaration', | |||
'indentation', | |||
'join_function', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should bump the composer.json
version of the fixer, to avoid regressions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I don't get what's on your mind.
In composer there is latest stable version of PHP CS Fixer.
And what regression?
@Ocramius with other CR team developers have you thinking a set of common roles for cs-fix? (thoughts after split :P ) |
@gianarb that would be great. But currently we do not know which rules are followed in actual codebase - they are followed in most cases, but to turn them on they usually need little fixing to made Travis happy about them. |
Np for this PR.. It's a general question 👍 |
@keradus thanks, merged after some further thoughts about it |
…icate_semicolon .php_cs - add few rules
Add few rules to PHP CS Fixer configuration that are already followed.