Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Conversation

filipp-kucheriavenko
Copy link
Contributor

Fixing of IntlException instance name

@Ocramius
Copy link
Member

Urgh, this is obviously because I couldn't get to write a test case for that exception -.- Thanks for spotting it!

@Ocramius Ocramius added this to the 2.3.5 milestone Jan 30, 2015
@Ocramius Ocramius self-assigned this Jan 30, 2015
@filipp-kucheriavenko
Copy link
Contributor Author

You welcome =). By the way, this exception exists in PHP >=5.5.0. I don't know how PHP < 5.5.0 will behave in this situation. I will try to write test for this when I have time.

@Ocramius
Copy link
Member

@filipp-qoma <5.5.0 uses a manual throwing mechanism

@Ocramius Ocramius closed this in f6a01fc Feb 2, 2015
Ocramius added a commit that referenced this pull request Feb 2, 2015
@Ocramius
Copy link
Member

Ocramius commented Feb 2, 2015

@filipp-qoma merged, thanks!

master: f6a01fc
develop: 56bb6fe

gianarb pushed a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants