This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
bugfix : options can't be passed to SeparatorToSeparator #7169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| } | ||
|
|
||
| } |
| * | ||
| * @param array $options | ||
| */ | ||
| public function __construct(array $options = array()) |
There was a problem hiding this comment.
What happens if I try to get multiple instances of a wordseparatortoseparator, each with different options?
There was a problem hiding this comment.
Hint: factory must implement the MutableCreationOptionsInterface
There was a problem hiding this comment.
Thank you very much for helping me to make this PR :-)
This was corrected.
There was a problem hiding this comment.
This constructor is also not needed anymore ;-)
| @@ -39,4 +39,38 @@ public function testLoadingInvalidFilterRaisesException() | |||
| $this->setExpectedException('Zend\Filter\Exception\RuntimeException'); | |||
| $this->filters->get('test'); | |||
| } | |||
|
|
|||
| public function testFilterSuccessfullyConstructed() | |||
There was a problem hiding this comment.
Consider adding @group annotations here:
/**
* @group 7169
*/
Ocramius
added a commit
that referenced
this pull request
Feb 2, 2015
Ocramius
added a commit
that referenced
this pull request
Feb 2, 2015
TomHAnderson
pushed a commit
to TomHAnderson/zf2
that referenced
this pull request
Feb 24, 2015
…ry from plugin manager
TomHAnderson
pushed a commit
to TomHAnderson/zf2
that referenced
this pull request
Feb 24, 2015
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…emoving duplicate filter entry from plugin manager
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…emoving redundant factory constructor
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…endframework#6666-options-cannot-be-passed-to-separator-to-separator-filter' Close zendframework/zendframework#7169
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…endframework#6666-options-cannot-be-passed-to-separator-to-separator-filter' into develop Close zendframework/zendframework#7169 Forward port zendframework/zendframework#7169
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes #6666 .
Patrick