This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Cache: fix mongo options #7203
Merged
Cache: fix mongo options #7203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -110,14 +66,8 @@ public function testSetResourceThrowsException() | |||
| $id = 'foo'; | |||
There was a problem hiding this comment.
This test fails currently, indicating that a Zend\Cache\Exception\InvalidArgumentException was not thrown. When I look at MongoDbResourceManager::setResource() there is no validation of the $resource argument. The typehint specifies array or MongoCollection, but does not test for anything other than MongoCollection (in which case it branches logic). I'll update it on merge to raise the exception if $resource is neither of the two types.
weierophinney
added a commit
that referenced
this pull request
Feb 25, 2015
Cache: fix mongo options
weierophinney
added a commit
that referenced
this pull request
Feb 25, 2015
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…che/fixMongoOptions Cache: fix mongo options
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the configuration of the mongo db storage adapter in the following form:
lib_options-> this was copied from moncached but the mongo db hasn't such an optionserver,database,collectioninto own configuration options (before part oflib_options)connection_optionsanddriver_optionsconnection_optionsso the default will be defined by ext/mongo.As of the mongo db cache storage adapter is new in 2.4 this will be no BC break until 2.4 is out!!
ping @Ocramius Hopefully soon enough for 2.4
ping @alexdenvir please review as author of this adapter