This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Ship a StandaloneExtensionManager for Zend\Feed\Reader #7254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially mimics the AbstractPluginManager, but does so as a standalone implementation of ExtensionManagerInterface.
Modified getExtensionManager to lazyload a StandaloneExtensionManager instead of ExtensionManager. This required an update to a test that was testing integration of registerExtension with the EM instance itself.
TRUE vs true
| @@ -0,0 +1,70 @@ | |||
| <?php | |||
There was a problem hiding this comment.
missing license here...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.2 or 2.3, we modified
Zend\Feedto reduce the number of dependencies, and introduced a separated interface for the extension manager to allow using a non-ServiceManager variant (which allowed reducing dependencies).This patch completes that work by introducing a
StandaloneExtensionManagerthat provides the base capabilities necessary to serve the shipped feed and entry extensions.Zend\Feed\Reader\Reader::getExtensionManager()has been modified to lazy-load this class when no other extension manager has been set.This implementation does NOT support registering custom extensions, as the
ExtensionManagerInterfacedoes not specify such capabilities. If users want to allow or support custom extensions, they would need to create their own implementation or extend the current implementation.This patch replaces #7179 and will resolve #6419.