This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow literal zero string as sql expression #7290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A sql expression cannot currently be a literal zero (useful in certain unions) since setExpression will never be called.
$select = new Select('foo');
$select->columns([
'bar' => new Expression('0') //fails, '0' is never set as the expression and the default empty string is used instead resulting in malformed sql
]);
|
Missing unit tests and fix build. |
|
@malukenho We have errors on the master branch right now due to a change in the Travis environment that causes 5.5 and 5.6 to error for However, @marcelto : we do need unit tests for this before I can accept it to merge. |
|
thanks for the explanation @weierophinney |
tests that the constructor will set the expression property even when the expression is the string '0'
|
added new test case |
weierophinney
added a commit
that referenced
this pull request
Mar 18, 2015
Allow literal zero string as sql expression
weierophinney
added a commit
that referenced
this pull request
Mar 18, 2015
|
Merged to develop for release with 2.4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sql expression cannot currently be a literal zero (useful in certain unions) since setExpression will never be called.
$select = new Select('foo');
$select->columns([
'bar' => new Expression('0') //fails, '0' is never set as the expression and the default empty string is used instead resulting in malformed sql
]);