-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix reflection for one line docblocks #7299
Conversation
@lstrojny build is failing |
{ | ||
/** Short Method Description */ | ||
public function doSomething() | ||
{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put each curly braces on one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it makes more sense to omit this class from our php_cs rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, that path is already excluded from our php-cs-fixer ruleset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This asset is actually supposed to have this particular structure to trigger a failure
@malukenho Note: please do not comment about build failures; we have status integration already with Travis, and authors will get notifications of build failures. Currently, all builds against master fail due to an environment issue anyways, so we need to check the results manually anyways to see if new, unknown failures are present. |
@weierophinney Okay, not problem! |
Fix reflection for one line docblocks
Merged to develop for release with 2.4. |
This fixes an issue where the parsing of single line docblocks fail and results in a syntax error with Ocramius/ProxyManager.
/cc @Ocramius