Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Do not throw exception when isset is used on AbstractOptions existing object variable #7342

Closed
wants to merge 1 commit into from
Closed

Do not throw exception when isset is used on AbstractOptions existing object variable #7342

wants to merge 1 commit into from

Conversation

Martin-P
Copy link
Contributor

Same fix as suggested by @rms230 in PR #7287. Split it up and slightly changed the assertion for BadMethodCallException.

Original description of #7287:

When calling isset() on an object variable that is a class extending AbstractOptions an exception is thrown.

An example useage of this is found in the EventManagerAwareTrait where the trait checks a class variable isset, if the class that is using the EventManagerAwareTrait extends AbstractOptions an exception is thrown.

This pull request fixes AbstractOptions by checking that the method exists and that the value is not equal to null, thus stopping the exception being thrown.

@Martin-P Martin-P mentioned this pull request Mar 18, 2015
Closed
@Martin-P
Copy link
Contributor Author

Ping @weierophinney
Just making sure this part of the original PR #7287 is included in the 2.4.0 release too 😃

weierophinney added a commit that referenced this pull request Mar 19, 2015
@weierophinney
Merge pull request #7342 from Martin-P/hotfix/abstractoptions-variabl…
6d3a299 
…e-using-isset

Do not throw exception when isset is used on AbstractOptions existing object variable

Conflicts:
	tests/ZendTest/Stdlib/OptionsTest.php
weierophinney added a commit that referenced this pull request Mar 19, 2015
@weierophinney
Merge branch 'feature/7342' into develop
d5f7362 
Close #7342
@weierophinney weierophinney added this to the 2.4.0 milestone Mar 19, 2015
@weierophinney
Copy link
Member

Pushed to develop for release with 2.4; thanks, @Martin-P !

@Martin-P Martin-P deleted the hotfix/abstractoptions-variable-using-isset branch April 4, 2015 15:15
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
@weierophinney
Merge pull request zendframework/zendframework#7342 from Martin-P/hot…
903bee2 
…fix/abstractoptions-variable-using-isset

Do not throw exception when isset is used on AbstractOptions existing object variable

Conflicts:
	tests/ZendTest/Stdlib/OptionsTest.php
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
@weierophinney
Merge branch 'feature/7342' into develop
66f08b6 
Close zendframework/zendframework#7342
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Stdlib
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Martin-P @weierophinney