Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Conversation

ASvi
Copy link

@ASvi ASvi commented Mar 23, 2015

Missing return statement in PHPDoc in AbstractNavigationFactory preparePages()

@weierophinney
Copy link
Member

In looking at this, the proper fix would be:

  • Document as null|array
  • Update the injectComponents() docblock's return value as array

as those are the actual return values. I can make that change on merge.

@weierophinney weierophinney added this to the 2.4.0 milestone Mar 23, 2015
weierophinney added a commit that referenced this pull request Mar 23, 2015
…-in-AbstractNavigationFactory

Missing return statement in PHPDoc in AbstractNavigationFactory
weierophinney added a commit that referenced this pull request Mar 23, 2015
@weierophinney weierophinney merged commit af429bf into zendframework:master Mar 23, 2015
weierophinney added a commit that referenced this pull request Mar 23, 2015
weierophinney added a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
…-return-statement-in-PHPDoc-in-AbstractNavigationFactory

Missing return statement in PHPDoc in AbstractNavigationFactory
weierophinney added a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants