This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Adjust ContentType regex to allow quoted strings and equals #7374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the regular expression in ContentType::fromString() to allow parameters to contain the equals (=) character, and be optionally enclosed in double quotes. For example the following header is perfectly valid, but does not get currently parsed by ContentType: Content-type: text/plain; charset="us-ascii" Whilst allowing the parameter to be enclosed in double quotes, it should not be included in the value itself, so these are outside the capture group in the regular expression. This change should resolve issue #7076.
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the regular expression in
ContentType::fromString()to allow parameters to contain the equals (
=) character, and beoptionally enclosed in double quotes. For example the following header
is perfectly valid, but does not get currently parsed by
ContentType:Whilst allowing the parameter to be enclosed in double quotes, it should
not be included in the value itself, so these are outside the capture
group in the regular expression.
This change should resolve issue #7076.