improvments for Zend\InputFilter #7392
Conversation
added some doc-blocks in Zend\InputFilter\*Interface little code improvements, for example signature say return $this and the method return nothing
|
i will fix the phpunit error tomorrow, sry=[ |
| @@ -52,9 +49,8 @@ public function canCreateServiceWithName(ServiceLocatorInterface $inputFilters, | |||
| * @param string $rName | |||
| * @return \Zend\InputFilter\InputFilterInterface | |||
| */ | |||
| public function createServiceWithName(ServiceLocatorInterface $inputFilters, $cName, $rName) | |||
There was a problem hiding this comment.
This is actually correct, because it is an instance of InputFilterPluginManager and not the ServiceManager itself.
There was a problem hiding this comment.
so the method signature has to be changed to AbstractPluginManager ?
For me was the problem that the ServiceLocatorInterface doesnt have the method getServiceLocator.
There was a problem hiding this comment.
No, it can stay just the way it was. Regarding the method getServiceLocator there already is an other issue for this and I think it depends on the outcome of that discussion whether it needs a change to AbstractPluginManager. See #7388.
…ady a discussion about that @ zendframework#7388 and the signature can not be changed to AbstractPluginManager, because the AbstractFactoryInterface does not allowed that.
|
thanks @Martin-P for the hint. I revert the InputFilterAbstractServiceFactory class. |
| * @return self | ||
| */ | ||
| public function setContinueIfEmpty($continueIfEmpty); | ||
|
|
There was a problem hiding this comment.
This is defined in EmptyContextInterface, and is there because we cannot add to existing interfaces (causes a BC break). This is why Input implements EmptyContextInterface.
|
@kokspflanze — As noted, with the current changes, I cannot merge this as it introduces BC breaks. If you remove the new methods from the |
|
@weierophinney thanks for the feedback, i will change it asap. =) |
|
After updating to 2.4.1, all the Zend\Filter\Boolean filters are causing validation errors. I have not investigated in detail, but is likely related to this change. |
|
@jerv13 can you give an example? |
HI,
added missing methods @ Zend\InputFilter\InputInterface
added some doc-blocks in Zend\InputFilter*Interface
little code improvements, for example signature say return $this and the method return nothing
Thanks=)