This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
increase loop performance by assign count() to variable #7413
Merged
weierophinney
merged 3 commits into
zendframework:master
from
samsonasik:performance-loop
May 4, 2015
Merged
increase loop performance by assign count() to variable #7413
weierophinney
merged 3 commits into
zendframework:master
from
samsonasik:performance-loop
May 4, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
loop performance by assign count() to variable
increase loop performance by assign count() to variable
Apr 4, 2015
@@ -135,7 +135,8 @@ protected function processAddColumns(PlatformInterface $adapterPlatform = null) | |||
if ($insert) { | |||
$j = isset($j) ? $j : 0; | |||
$sql = substr_replace($sql, $insert, $insertStart[$j], 0); | |||
for (; $j < count($insertStart); ++$j) { | |||
$countInsertStart = count($insertStart); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Count is a noun here not a verb, so it should be $insertStartCount
instead of $countInsertStart
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done ;)
samsonasik
force-pushed
the
performance-loop
branch
from
April 10, 2015 00:54
9a88d26
to
15aa722
Compare
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
increase loop performance by assign count() to variable
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
weierophinney
added a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
…erformance-loop increase loop performance by assign count() to variable
weierophinney
added a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test :
Result :