This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
update variable name : $myParams to $pageParams #7425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -130,18 +130,18 @@ public function isActive($recursive = false) | |||
| $reqParams['controller'] = $reqParams[ModuleRouteListener::ORIGINAL_CONTROLLER]; | |||
| } | |||
|
|
|||
| $myParams = $this->params; | |||
| $routeMatchParams = $this->params; | |||
There was a problem hiding this comment.
These are not the parameters from the RouteMatch, but parameters from the MvcPage itself. The parameters from the RouteMatch are on line 127 in the variable $reqParams (also not the best name, better is $requestParams or use $routeMatchParams here, because these are the parameters from the RouteMatch object).
If you want to rename $myParams, $pageParams is a better choice, because after all those are the parameters of the MvcPage.
samsonasik
changed the title
weierophinney
added a commit
that referenced
this pull request
May 6, 2015
update variable name : $myParams to $pageParams
weierophinney
added a commit
that referenced
this pull request
May 6, 2015
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…ar-name update variable name : $myParams to $pageParams
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.