This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

[test] Replace assert(True|False) with more appropriate assertions where possible #7476

Merged

weierophinney merged 30 commits into zendframework:master from Maks3w:hotix/remove-evil-assertBoolean-not-boolean-values

May 4, 2015

Member

Maks3w commented May 1, 2015

This PR aims to remove uses of asserTrue and assertFalse.

PHPUnit provides alternative assertions specific for certain cases and provides useful information about the nature of the failure.

Maks3w added this to the 2.5.0 milestone

Maks3w added the enhancement label

Maks3w added 28 commits

May 1, 2015 18:53


          [test] Replace assertTrue(is_FOO) with assertInternalType('FOO')

8e6f7e8


          [test] Replace assertFalse(is_FOO) with assertNotInternalType('FOO')

c2d4c02


          [test] Replace assertTrue(in_array) with assertContains

31b9a65


          [test] Replace assertFalse(in_array) with assertNotContains

7a889e7


          [test] Replace assertTrue(array_key_exists) with assertArrayHasKey

80884a3


          [test] Replace assertFalse(array_key_exists) with assertArrayNotHasKey

d93f0aa


          [test] Replace assertTrue(false) with fail

a0ec062


          [test] Replace assertTrue(file_exists) with assertFileExists

d29b6b9


          [test] Replace assertFalse(file_exists) with assertFileNotExists

fe279b8


          [test] Replace assertTrue(null == foo) with assertNull(foo)

e159351


          [test] Replace assertTrue(empty) with assertEmpty

fd6dbc2


          [test] Replace assertTrue(!empty) with assertNotEmpty

5e80e01


          [test] Replace assertFalse(empty) with assertEmpty

6ae3da1


          [test] Replace assertTrue(instanceof) with assertInstanceOf

a0b87c0


          [test] Replace assertFalse(instanceof) with assertNotInstanceOf

38d37f8


          [test] Replace assertTrue(count(foo) == 0) with assertEmpty(foo)

8205e31


          [test] Replace assertTrue(count(foo) > 0) with assertNotEmpty(foo)

06d8946


          [test] Replace assertTrue(x == count(foo)) with assertCount(x, foo)

563318d


          [test] Replace assertTrue(x == y) with assertEquals(x, y)

e1dbba0


          [test] Replace assertFalse(x == y) with assertNotEquals(x, y)

2cbc9f7


          [test] Replace assertTrue(x != y) with assertNotEquals(x, y)

e32efa5


          [test] Replace assertTrue(>,<,>=,<=) with assertGreater/Less/OrEquals

750ba85


          [test] Replace assertTrue(x == y) with assertEquals(x, y)

b61ec03


          [test] Replace assertTrue(preg_match/strpos/strstr) with assertContains

659d6fe

Only when string offset is not relevant


          [test] Replace assertTrue(strpos == 0) with assertStringStartsWith

b704b63


          [test] Replace assertTrue(false == foo) with assertFalse(foo)

da9b95e


          [test] Replace assertTrue(false !== foo) with assertTrue(foo)

ddaa340


          [test] Use assertNotFalse when 'false' is used as error

f047448

weierophinney added a commit to zendframework/zend-console that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

cff1d32

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-console that referenced this pull request


          Merge branch 'hotfix/7476'

48efbd9

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-filter that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

731eaf1

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-filter that referenced this pull request


          Merge branch 'hotfix/7476'

e440aa7

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-ldap that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

47347d6

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-ldap that referenced this pull request


          Merge branch 'hotfix/7476'

61e9069

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-json that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

8bcd81d

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-json that referenced this pull request


          Merge branch 'hotfix/7476'

f24562c

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-validator that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

f158314

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-validator that referenced this pull request


          Merge branch 'hotfix/7476'

9f3a112

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-file that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

6018a47

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-file that referenced this pull request


          Merge branch 'hotfix/7476'

0348f0e

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-dom that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

96b3bd6

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-dom that referenced this pull request


          Merge branch 'hotfix/7476'

be1e921

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-session that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

9845b1f

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-session that referenced this pull request


          Merge branch 'hotfix/7476'

d77a07c

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-log that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

0c5c31a

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-log that referenced this pull request


          Merge branch 'hotfix/7476'

3de1e33

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-cache that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

ff73321

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-cache that referenced this pull request


          Merge branch 'hotfix/7476'

784c8fb

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-soap that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

e19f76b

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-soap that referenced this pull request


          Merge branch 'hotfix/7476'

8c0b6a1

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-mime that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

a8efeb8

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-mime that referenced this pull request


          Merge branch 'hotfix/7476'

fb93cfd

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-view that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

33f924f

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-view that referenced this pull request


          Merge branch 'hotfix/7476'

24a6cea

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-feed that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

e2d64e9

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-feed that referenced this pull request


          Merge branch 'hotfix/7476'

d913768

Close zendframework/zendframework#7476

weierophinney added a commit to zendframework/zend-permissions-acl that referenced this pull request


          Merge pull request zendframework/zendframework#7476 from Maks3w/hotix…

7d281a7

…/remove-evil-assertBoolean-not-boolean-values

[test] Remove evil assert boolean for not boolean values

weierophinney added a commit to zendframework/zend-permissions-acl that referenced this pull request


          Merge branch 'hotfix/7476'

52d7001

Close zendframework/zendframework#7476

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels