Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting the "module" package.json property #7

Closed
guybedford opened this issue Jun 12, 2018 · 2 comments
Closed

Supporting the "module" package.json property #7

guybedford opened this issue Jun 12, 2018 · 2 comments

Comments

@guybedford
Copy link
Contributor

The way this proposal handles the "default" could work just as well for the "module" property already in use in the ecosystem by users.

Previously my attempts to work with the "module" property failed (like the In Defense of JS proposal) because it was treating the module property as a package-level flag.

Rather the way this proposal works, would work naturally with the way users already use the "module" property.

Would you be open to a PR to add the adjustment here?

@guybedford
Copy link
Contributor Author

(basically working like the "default" property in the package.json file mentioned here - #6 (comment))

@zenparsing
Copy link
Owner

Yes, feel free to make a PR and we can discuss any details there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants