fix(server): return an object without primary data for delete route (#1938)

Author: ymc9

packages/server/src/api/rest/index.ts

@@ -1103,8 +1103,8 @@ class RequestHandler extends APIHandlerBase {
             where: this.makePrismaIdFilter(typeInfo.idFields, resourceId),
         });
         return {
-            status: 204,
-            body: undefined,
+            status: 200,
+            body: { meta: {} },
         };
     }
 

packages/server/tests/adapter/express.test.ts

@@ -190,7 +190,7 @@ describe('Express adapter tests - rest handler', () => {
         expect(r.body.data.attributes.email).toBe('user1@def.com');
 
         r = await request(app).delete(makeUrl('/api/user/user1'));
-        expect(r.status).toBe(204);
+        expect(r.status).toBe(200);
         expect(await prisma.user.findMany()).toHaveLength(0);
     });
 });

packages/server/tests/adapter/fastify.test.ts

@@ -233,7 +233,7 @@ describe('Fastify adapter tests - rest handler', () => {
         expect(r.json().data.attributes.email).toBe('user1@def.com');
 
         r = await app.inject({ method: 'DELETE', url: '/api/user/user1' });
-        expect(r.statusCode).toBe(204);
+        expect(r.statusCode).toBe(200);
         expect(await prisma.user.findMany()).toHaveLength(0);
     });
 });

packages/server/tests/adapter/hono.test.ts

@@ -167,7 +167,7 @@ describe('Hono adapter tests - rest handler', () => {
         expect((await unmarshal(r)).data.attributes.email).toBe('user1@def.com');
 
         r = await handler(makeRequest('DELETE', makeUrl(makeUrl('/api/user/user1'))));
-        expect(r.status).toBe(204);
+        expect(r.status).toBe(200);
         expect(await prisma.user.findMany()).toHaveLength(0);
     });
 });

packages/server/tests/adapter/next.test.ts

@@ -307,7 +307,7 @@ model M {
                 expect(resp.body.data.attributes.value).toBe(2);
             });
 
-        await makeTestClient('/m/1', options).del('/').expect(204);
+        await makeTestClient('/m/1', options).del('/').expect(200);
         expect(await prisma.m.count()).toBe(0);
     });
 });

packages/server/tests/adapter/sveltekit.test.ts

@@ -164,7 +164,7 @@ describe('SvelteKit adapter tests - rest handler', () => {
         expect((await unmarshal(r)).data.attributes.email).toBe('user1@def.com');
 
         r = await handler(makeRequest('DELETE', makeUrl(makeUrl('/api/user/user1'))));
-        expect(r.status).toBe(204);
+        expect(r.status).toBe(200);
         expect(await prisma.user.findMany()).toHaveLength(0);
     });
 });

packages/server/tests/api/rest.test.ts

@@ -2340,8 +2340,8 @@ describe('REST server tests', () => {
                         prisma,
                     });
 
-                    expect(r.status).toBe(204);
-                    expect(r.body).toBeUndefined();
+                    expect(r.status).toBe(200);
+                    expect(r.body).toMatchObject({ meta: {} });
                 });
 
                 it('deletes an item with compound id', async () => {
@@ -2355,8 +2355,8 @@ describe('REST server tests', () => {
                         path: `/postLike/1${idDivider}user1`,
                         prisma,
                     });
-                    expect(r.status).toBe(204);
-                    expect(r.body).toBeUndefined();
+                    expect(r.status).toBe(200);
+                    expect(r.body).toMatchObject({ meta: {} });
                 });
 
                 it('returns 404 if the user does not exist', async () => {