Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noodle/Chroma custom events do not work when mod is enabled. #4

Open
Mawntee opened this issue Sep 22, 2024 · 0 comments
Open

Noodle/Chroma custom events do not work when mod is enabled. #4

Mawntee opened this issue Sep 22, 2024 · 0 comments

Comments

@Mawntee
Copy link

Mawntee commented Sep 22, 2024

Versions:

  • Beat Saber: 1.29.1
  • AccessAbility (AccessAbility): 7.1.0
  • Heck (_Heck): 1.5.0
  • LookupID (LookupID): 1.0.1
  • Chroma (Chroma): 2.8.0
  • NoodleExtensions (NoodleExtensions): 1.6.0
  • CustomJSONData (CustomJSONData): 2.5.2

Was helping a friend try to diagnose some Noodle issues, and after a lot of back and fourth we narrowed it down to custom events not working if the mod was enabled in game. Hitting the toggle to disable the mod fixed the issue with the noodle maps.

It appears as though when it's enabled, any animations and stuff applied directly to objects will work fine, but custom animation events such as an "AnimateTrack", "AssignPathAnimation" will just not do anything.

I haven't done much extensive testing around this, but it appears as though some customData elements (like everything statically under "environment") work totally fine without issue, and it's just a few animation events that refuse to work.
Unfortunately, I'm not entirely sure why some things decide to work, and others do not.

Example/Testing:

In my map "Distaster V2" (Standard Ex+) the highway mirror's position and scale isn't set, and is instead left at it's default position. This is just with the mod enabled, and no other settings changed:
image
image

And here it is with the mod disabled:
image
image

For context of the highway specifically, here's the relevant bits of json from the maps dif file that move it around:

{
  "version" : "3.2.0",
  "customData" : {
    "environment" : [
    // Disables original highway mirror
      {
        "id" : "Environment\\.\\[\\d\\]TrackMirror$",
        "lookupMethod" : "Regex",
        "active" : false
      },
      // Creates a duplicate of the mirror, enables it, and assigns it the track name "trackMirror"
      {
        "id" : "Environment\\.\\[\\d\\]TrackMirror$",
        "lookupMethod" : "Regex",
        "track" : "trackMirror",
        "duplicate" : 1,
        "active" : true
      },
    .  .  .
    ],
    "customEvents" : [
    .  .  .
   // AnimateTrack event on beat 0 to set the pos/rot/scale of the duplicated mirror
      {
        "b" : 0,
        "t" : "AnimateTrack",
        "d" : {
          "track" : "trackMirror",
          "duration" : 0,
          "scale" : [[420,1,666,0]],
          "position" : [[0,-4.14,-252.00002,0]],
          "rotation" : [[0,0,0,0]]
        }
      },
    . . . 
    // rest of the difficulty file

There was also another map which had similar issues if that helps with the debugging process.

Alohaii - Magazines uses a bunch of fake notes to allow the arc art to work.
Each fake note for the arcs are assigned a track called "mwt_farcFix", then there is a single AnimateTrack event on beat 0 which sets the scale, and dissolves of the blocks/arrows of the note.
With the mod enabled, all of these notes are visible and full size.

I've seen issues like this before with Noodle where some events work and others don't.
This happens when you typo or whiff one of the event properties and put the wrong thing in, or mess up one of the values/easings, and then it will break the rest of the events down the chain.

My only hunch is that this mod might be messing with the notes scale/dissolve properties or something, and a similar error is occurring?

Also, I wasn't able to find anything related to this in the logs :/
So sorry about that.

If you need help with this, or want to test more things about it, feel free to hmu on Discord: @Mawntee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant