vega_sdk_riscv: Ignore GCC warning about potential uninitialized variable

keith-packard · keith-packard · commit 218777415d46 · 2022-10-19T10:59:36.000-07:00
When -ffreestanding is not enabled, and GCC is able to use it's
knowledge of memset semantics, it sometimes gets it wrong, as in this
case. I'm not quite sure what is confusing it here, but the code sure
looks correct.

Signed-off-by: Keith Packard &lt;keithp@keithp.com&gt;
diff --git a/vega_sdk_riscv/devices/RV32M1/drivers/fsl_cau3_ble.c b/vega_sdk_riscv/devices/RV32M1/drivers/fsl_cau3_ble.c
@@ -4077,6 +4077,9 @@ status_t CAU3_CHACHA20_POLY1305_SetKey(CAU3_Type *base, cau3_handle_t *handle, c
 
 static status_t cau3_load_nonce(CAU3_Type *base, const uint8_t *nonce, cau3_key_slot_t keySlot)
 {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+
     union {
         uint8_t b[16];
         uint32_t w[4];
@@ -4092,6 +4095,7 @@ static status_t cau3_load_nonce(CAU3_Type *base, const uint8_t *nonce, cau3_key_
     tempIv.w[2] = __REV(tempIv.w[2]);
 
     return CAU3_LoadKeyInitVector(base, tempIv.b, keySlot, kCAU3_TaskDonePoll);
+#pragma GCC diagnostic pop
 }
 
 status_t CAU3_CHACHA20_POLY1305_Encrypt(CAU3_Type *base,

Original file line number	Diff line number	Diff line change
`@@ -4077,6 +4077,9 @@ status_t CAU3_CHACHA20_POLY1305_SetKey(CAU3_Type base, cau3_handle_t handle, c`
`4077`	`4077`
`4078`	`4078`	`static status_t cau3_load_nonce(CAU3_Type base, const uint8_t nonce, cau3_key_slot_t keySlot)`
`4079`	`4079`	`{`
	`4080`	`+#pragma GCC diagnostic push`
	`4081`	`+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"`
	`4082`	`+`
`4080`	`4083`	`union {`
`4081`	`4084`	`uint8_t b[16];`
`4082`	`4085`	`uint32_t w[4];`
`@@ -4092,6 +4095,7 @@ static status_t cau3_load_nonce(CAU3_Type base, const uint8_t nonce, cau3_key_`
`4092`	`4095`	`tempIv.w[2] = __REV(tempIv.w[2]);`
`4093`	`4096`
`4094`	`4097`	`return CAU3_LoadKeyInitVector(base, tempIv.b, keySlot, kCAU3_TaskDonePoll);`
	`4098`	`+#pragma GCC diagnostic pop`
`4095`	`4099`	`}`
`4096`	`4100`
`4097`	`4101`	`status_t CAU3_CHACHA20_POLY1305_Encrypt(CAU3_Type *base,`