tests: smf: replace raw smf_ctx casts with SMF_CTX() macro

vlad-kulikov · cfriedt · commit 20425ec6cc98 · 2025-10-18T20:35:00.000-04:00
Use SMF_CTX() in SMF unit tests instead of (struct smf_ctx *) casts for
clarity and consistency. No functional change.

Signed-off-by: Vlad Kulikov &lt;vlad_kulikov_c@pm.me&gt;
diff --git a/tests/lib/smf/src/test_lib_flat_smf.c b/tests/lib/smf/src/test_lib_flat_smf.c
@@ -264,10 +264,10 @@ ZTEST(smf_tests, test_smf_flat)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = NONE;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj)) {
+		if (smf_run_state(SMF_CTX(&test_obj))) {
 			break;
 		}
 	}
@@ -280,10 +280,10 @@ ZTEST(smf_tests, test_smf_flat)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = ENTRY;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj)) {
+		if (smf_run_state(SMF_CTX(&test_obj))) {
 			break;
 		}
 	}
@@ -297,10 +297,10 @@ ZTEST(smf_tests, test_smf_flat)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = RUN;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj)) {
+		if (smf_run_state(SMF_CTX(&test_obj))) {
 			break;
 		}
 	}
@@ -314,10 +314,10 @@ ZTEST(smf_tests, test_smf_flat)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = EXIT;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj)) {
+		if (smf_run_state(SMF_CTX(&test_obj))) {
 			break;
 		}
 	}
diff --git a/tests/lib/smf/src/test_lib_hierarchical_5_ancestor_smf.c b/tests/lib/smf/src/test_lib_hierarchical_5_ancestor_smf.c
@@ -411,10 +411,10 @@ ZTEST(smf_tests, test_smf_hierarchical_5_ancestors)
 {
 	test_obj.tv_idx = 0;
 	test_obj.transition_bits = 0;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
diff --git a/tests/lib/smf/src/test_lib_hierarchical_smf.c b/tests/lib/smf/src/test_lib_hierarchical_smf.c
@@ -381,10 +381,10 @@ ZTEST(smf_tests, test_smf_hierarchical)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = NONE;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -397,10 +397,10 @@ ZTEST(smf_tests, test_smf_hierarchical)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = PARENT_ENTRY;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -414,10 +414,10 @@ ZTEST(smf_tests, test_smf_hierarchical)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = PARENT_RUN;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -431,10 +431,10 @@ ZTEST(smf_tests, test_smf_hierarchical)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = PARENT_EXIT;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -448,10 +448,10 @@ ZTEST(smf_tests, test_smf_hierarchical)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = ENTRY;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -465,10 +465,10 @@ ZTEST(smf_tests, test_smf_hierarchical)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = RUN;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -482,10 +482,10 @@ ZTEST(smf_tests, test_smf_hierarchical)
 
 	test_obj.transition_bits = 0;
 	test_obj.terminate = EXIT;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
diff --git a/tests/lib/smf/src/test_lib_self_transition_smf.c b/tests/lib/smf/src/test_lib_self_transition_smf.c
@@ -469,10 +469,10 @@ ZTEST(smf_tests, test_smf_self_transition)
 	test_obj.transition_bits = 0;
 	test_obj.first_time = FIRST_TIME_BITS;
 	test_obj.terminate = NONE;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[PARENT_AB]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[PARENT_AB]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -486,10 +486,10 @@ ZTEST(smf_tests, test_smf_self_transition)
 	test_obj.transition_bits = 0;
 	test_obj.first_time = FIRST_TIME_BITS;
 	test_obj.terminate = PARENT_ENTRY;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[PARENT_AB]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[PARENT_AB]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -504,10 +504,10 @@ ZTEST(smf_tests, test_smf_self_transition)
 	test_obj.transition_bits = 0;
 	test_obj.first_time = FIRST_TIME_BITS;
 	test_obj.terminate = PARENT_RUN;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[PARENT_AB]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[PARENT_AB]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -522,10 +522,10 @@ ZTEST(smf_tests, test_smf_self_transition)
 	test_obj.transition_bits = 0;
 	test_obj.first_time = FIRST_TIME_BITS;
 	test_obj.terminate = PARENT_EXIT;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[PARENT_AB]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[PARENT_AB]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -540,10 +540,10 @@ ZTEST(smf_tests, test_smf_self_transition)
 	test_obj.transition_bits = 0;
 	test_obj.first_time = FIRST_TIME_BITS;
 	test_obj.terminate = ENTRY;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[PARENT_AB]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[PARENT_AB]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -558,10 +558,10 @@ ZTEST(smf_tests, test_smf_self_transition)
 	test_obj.transition_bits = 0;
 	test_obj.first_time = FIRST_TIME_BITS;
 	test_obj.terminate = RUN;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[PARENT_AB]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[PARENT_AB]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}
@@ -576,10 +576,10 @@ ZTEST(smf_tests, test_smf_self_transition)
 	test_obj.transition_bits = 0;
 	test_obj.first_time = FIRST_TIME_BITS;
 	test_obj.terminate = EXIT;
-	smf_set_initial((struct smf_ctx *)&test_obj, &test_states[PARENT_AB]);
+	smf_set_initial(SMF_CTX(&test_obj), &test_states[PARENT_AB]);
 
 	for (int i = 0; i < SMF_RUN; i++) {
-		if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {
+		if (smf_run_state(SMF_CTX(&test_obj)) < 0) {
 			break;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -264,10 +264,10 @@ ZTEST(smf_tests, test_smf_flat)`
`264`	`264`
`265`	`265`	`test_obj.transition_bits = 0;`
`266`	`266`	`test_obj.terminate = NONE;`
`267`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`267`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`268`	`268`
`269`	`269`	`for (int i = 0; i < SMF_RUN; i++) {`
`270`		`- if (smf_run_state((struct smf_ctx *)&test_obj)) {`
	`270`	`+ if (smf_run_state(SMF_CTX(&test_obj))) {`
`271`	`271`	`break;`
`272`	`272`	`}`
`273`	`273`	`}`
`@@ -280,10 +280,10 @@ ZTEST(smf_tests, test_smf_flat)`
`280`	`280`
`281`	`281`	`test_obj.transition_bits = 0;`
`282`	`282`	`test_obj.terminate = ENTRY;`
`283`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`283`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`284`	`284`
`285`	`285`	`for (int i = 0; i < SMF_RUN; i++) {`
`286`		`- if (smf_run_state((struct smf_ctx *)&test_obj)) {`
	`286`	`+ if (smf_run_state(SMF_CTX(&test_obj))) {`
`287`	`287`	`break;`
`288`	`288`	`}`
`289`	`289`	`}`
`@@ -297,10 +297,10 @@ ZTEST(smf_tests, test_smf_flat)`
`297`	`297`
`298`	`298`	`test_obj.transition_bits = 0;`
`299`	`299`	`test_obj.terminate = RUN;`
`300`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`300`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`301`	`301`
`302`	`302`	`for (int i = 0; i < SMF_RUN; i++) {`
`303`		`- if (smf_run_state((struct smf_ctx *)&test_obj)) {`
	`303`	`+ if (smf_run_state(SMF_CTX(&test_obj))) {`
`304`	`304`	`break;`
`305`	`305`	`}`
`306`	`306`	`}`
`@@ -314,10 +314,10 @@ ZTEST(smf_tests, test_smf_flat)`
`314`	`314`
`315`	`315`	`test_obj.transition_bits = 0;`
`316`	`316`	`test_obj.terminate = EXIT;`
`317`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`317`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`318`	`318`
`319`	`319`	`for (int i = 0; i < SMF_RUN; i++) {`
`320`		`- if (smf_run_state((struct smf_ctx *)&test_obj)) {`
	`320`	`+ if (smf_run_state(SMF_CTX(&test_obj))) {`
`321`	`321`	`break;`
`322`	`322`	`}`
`323`	`323`	`}`
Original file line number	Diff line number	Diff line change
`@@ -411,10 +411,10 @@ ZTEST(smf_tests, test_smf_hierarchical_5_ancestors)`
`411`	`411`	`{`
`412`	`412`	`test_obj.tv_idx = 0;`
`413`	`413`	`test_obj.transition_bits = 0;`
`414`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[A]);`
	`414`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[A]);`
`415`	`415`
`416`	`416`	`for (int i = 0; i < SMF_RUN; i++) {`
`417`		`- if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {`
	`417`	`+ if (smf_run_state(SMF_CTX(&test_obj)) < 0) {`
`418`	`418`	`break;`
`419`	`419`	`}`
`420`	`420`	`}`
Original file line number	Diff line number	Diff line change
`@@ -381,10 +381,10 @@ ZTEST(smf_tests, test_smf_hierarchical)`
`381`	`381`
`382`	`382`	`test_obj.transition_bits = 0;`
`383`	`383`	`test_obj.terminate = NONE;`
`384`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`384`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`385`	`385`
`386`	`386`	`for (int i = 0; i < SMF_RUN; i++) {`
`387`		`- if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {`
	`387`	`+ if (smf_run_state(SMF_CTX(&test_obj)) < 0) {`
`388`	`388`	`break;`
`389`	`389`	`}`
`390`	`390`	`}`
`@@ -397,10 +397,10 @@ ZTEST(smf_tests, test_smf_hierarchical)`
`397`	`397`
`398`	`398`	`test_obj.transition_bits = 0;`
`399`	`399`	`test_obj.terminate = PARENT_ENTRY;`
`400`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`400`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`401`	`401`
`402`	`402`	`for (int i = 0; i < SMF_RUN; i++) {`
`403`		`- if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {`
	`403`	`+ if (smf_run_state(SMF_CTX(&test_obj)) < 0) {`
`404`	`404`	`break;`
`405`	`405`	`}`
`406`	`406`	`}`
`@@ -414,10 +414,10 @@ ZTEST(smf_tests, test_smf_hierarchical)`
`414`	`414`
`415`	`415`	`test_obj.transition_bits = 0;`
`416`	`416`	`test_obj.terminate = PARENT_RUN;`
`417`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`417`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`418`	`418`
`419`	`419`	`for (int i = 0; i < SMF_RUN; i++) {`
`420`		`- if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {`
	`420`	`+ if (smf_run_state(SMF_CTX(&test_obj)) < 0) {`
`421`	`421`	`break;`
`422`	`422`	`}`
`423`	`423`	`}`
`@@ -431,10 +431,10 @@ ZTEST(smf_tests, test_smf_hierarchical)`
`431`	`431`
`432`	`432`	`test_obj.transition_bits = 0;`
`433`	`433`	`test_obj.terminate = PARENT_EXIT;`
`434`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`434`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`435`	`435`
`436`	`436`	`for (int i = 0; i < SMF_RUN; i++) {`
`437`		`- if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {`
	`437`	`+ if (smf_run_state(SMF_CTX(&test_obj)) < 0) {`
`438`	`438`	`break;`
`439`	`439`	`}`
`440`	`440`	`}`
`@@ -448,10 +448,10 @@ ZTEST(smf_tests, test_smf_hierarchical)`
`448`	`448`
`449`	`449`	`test_obj.transition_bits = 0;`
`450`	`450`	`test_obj.terminate = ENTRY;`
`451`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`451`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`452`	`452`
`453`	`453`	`for (int i = 0; i < SMF_RUN; i++) {`
`454`		`- if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {`
	`454`	`+ if (smf_run_state(SMF_CTX(&test_obj)) < 0) {`
`455`	`455`	`break;`
`456`	`456`	`}`
`457`	`457`	`}`
`@@ -465,10 +465,10 @@ ZTEST(smf_tests, test_smf_hierarchical)`
`465`	`465`
`466`	`466`	`test_obj.transition_bits = 0;`
`467`	`467`	`test_obj.terminate = RUN;`
`468`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`468`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`469`	`469`
`470`	`470`	`for (int i = 0; i < SMF_RUN; i++) {`
`471`		`- if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {`
	`471`	`+ if (smf_run_state(SMF_CTX(&test_obj)) < 0) {`
`472`	`472`	`break;`
`473`	`473`	`}`
`474`	`474`	`}`
`@@ -482,10 +482,10 @@ ZTEST(smf_tests, test_smf_hierarchical)`
`482`	`482`
`483`	`483`	`test_obj.transition_bits = 0;`
`484`	`484`	`test_obj.terminate = EXIT;`
`485`		`- smf_set_initial((struct smf_ctx *)&test_obj, &test_states[STATE_A]);`
	`485`	`+ smf_set_initial(SMF_CTX(&test_obj), &test_states[STATE_A]);`
`486`	`486`
`487`	`487`	`for (int i = 0; i < SMF_RUN; i++) {`
`488`		`- if (smf_run_state((struct smf_ctx *)&test_obj) < 0) {`
	`488`	`+ if (smf_run_state(SMF_CTX(&test_obj)) < 0) {`
`489`	`489`	`break;`
`490`	`490`	`}`
`491`	`491`	`}`