Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: poll: outdated check for expired timeout #12264

Closed
pabigot opened this issue Jan 2, 2019 · 1 comment
Closed

kernel: poll: outdated check for expired timeout #12264

pabigot opened this issue Jan 2, 2019 · 1 comment
Assignees
Labels
area: Timer Timer bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Jan 2, 2019

signal_poll_event in kernel/poll.c invokes _is_thread_timeout_expired, which checks whether a timeout dticks field has the flag value _EXPIRED. After the timer updates in 987c0e5 the only reference to that value is in benchmarks/timing_info/src/msg_passing_bench.c.

Since there's no way the test could succeed in any other condition some cleanup needs to be done.

@pabigot pabigot added Enhancement Changes/Updates/Additions to existing features area: Timer Timer labels Jan 2, 2019
@nashif nashif added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug and removed Enhancement Changes/Updates/Additions to existing features labels Feb 13, 2020
@nashif
Copy link
Member

nashif commented Mar 11, 2020

1c4177d changed signal_poll_event and removed _is_thread_timeout_expired, so this issue is not valid anymore.

@nashif nashif closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Timer Timer bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

3 participants