Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize generated include files #16436

Closed
erwango opened this issue May 28, 2019 · 3 comments
Closed

Organize generated include files #16436

erwango opened this issue May 28, 2019 · 3 comments
Labels
area: Build System Enhancement Changes/Updates/Additions to existing features

Comments

@erwango
Copy link
Member

erwango commented May 28, 2019

Is your enhancement proposal related to a problem? Please describe.
We can generate a lot of include files at build, all under zephyr/include/generated.
We're generating files that belong to various type: header, linker files, ...

It would be nice to have a sublevel folder hierarchy.
Note: there is already a sublevel zephyr/include/generated\syscalls

Describe the solution you'd like
Generate include files under a sublevel category:

generated
 └── include
     ├── linker
     ├── dts
     ├── kernel
     ├── ...
     └── syscalls

Describe alternatives you've considered
Sit down and watch the mess growing

@erwango erwango added Enhancement Changes/Updates/Additions to existing features area: Build System labels May 28, 2019
@ulfalizer
Copy link
Collaborator

ulfalizer commented May 28, 2019

The naming seems a bit redundant at the moment, like zephyr/include/generated/generated_dts_board_fixups.h. I wonder if it could just be zephyr/include/dts_board_fixups.h, since it's easy to understand that it's generated anyway when it's in the build directory.

Flat hierarchies are nice, IMO, and avoiding directories that only have another directory in them (like zephyr/include/, which only seems to have zephyr/include/generated/ in it).

@erwango
Copy link
Member Author

erwango commented May 29, 2019

The naming seems a bit redundant at the moment, like zephyr/include/generated/generated_dts_board_fixups.h. I wonder if it could just be zephyr/include/dts_board_fixups.h, since it's easy to understand that it's generated anyway when it's in the build directory.

What about zephyr/include/dts/board_fixups.h then ? ;-)

Flat hierarchies are nice, IMO, and avoiding directories that only have another directory in them (like zephyr/include/, which only seems to have zephyr/include/generated/ in it).

Agreed, not sure the include makes any sense here (besides we can find .c and .ld files in it).

@erwango
Copy link
Member Author

erwango commented May 6, 2020

Closing as the current solution is far from description on this PR

@erwango erwango closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Build System Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

2 participants