Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCIe build warnings from devicetree #16721

Closed
ghost opened this issue Jun 10, 2019 · 7 comments
Closed

PCIe build warnings from devicetree #16721

ghost opened this issue Jun 10, 2019 · 7 comments
Labels
area: Drivers area: X86 x86 Architecture (32-bit) bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone

Comments

@ghost
Copy link

ghost commented Jun 10, 2019

Describe the bug

When building targets with PCIe devices in devicetree, warnings are produced that need to be silenced.

To Reproduce
Steps to reproduce the behavior:

  1. mkdir build; cd build
  2. cmake -DBOARD=up_squared
  3. make
  4. See warnings like up_squared.dts.pre.tmp:94.15-105.5: Warning (simple_bus_reg): /soc/i2c@1: simple-bus unit address format error, expected "b100"

Impact
It's an annoyance (and bad form).

@ghost ghost added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug area: Drivers area: X86 x86 Architecture (32-bit) labels Jun 10, 2019
@ghost ghost self-assigned this Jun 10, 2019
@ghost
Copy link
Author

ghost commented Jun 21, 2019

@galak and @ulfalizer are rewriting the devicetree scripts. Waiting on that before I fix this.

@ghost ghost added priority: medium Medium impact/importance bug and removed priority: low Low impact/importance bug labels Aug 25, 2019
@ghost
Copy link
Author

ghost commented Aug 25, 2019

Changed to medium-priority bug to be sure this stays on our radar for 2.0 release.

Now that the new devicetree scripts are in place I can proceed to fix properly.

@galak
Copy link
Collaborator

galak commented Aug 26, 2019

@gnuless can we leave this as low, I don't think we're going to fix / address this in the 2.0.0 timeframe.

@ioannisg
Copy link
Member

@gnuless pls, give it a try if you have time :p

@ghost
Copy link
Author

ghost commented Aug 26, 2019

@galak @ioannisg I'm going to try to get a PR in for this this week. With the new DT scripts in place, I'm getting pagefulls of warnings during the configuration process for any platform that uses PCIe devices, and that's just really, really bad form.

@jenmwms jenmwms added this to the v2.0.0 milestone Aug 27, 2019
@ghost ghost modified the milestones: v2.0.0, v2.1.0 Aug 27, 2019
@ghost ghost added priority: low Low impact/importance bug and removed priority: medium Medium impact/importance bug labels Aug 27, 2019
@ghost
Copy link
Author

ghost commented Aug 27, 2019

@galak is right, it's going to take longer than we have to get all the changes integrated, so moving to 2.1.0 and changing back to low.

@ghost
Copy link
Author

ghost commented Sep 6, 2019

@galak can you revisit this now that the devicetree stuff has been rewritten? the new Python scripts double the number of warnings spewed during the configuration process. I'm really not sure I want to start tinkering with work-in-progress devicetree code, but I imagine restructuring the .dts files and emitting b/d/f for PCI devices can't be all that hard.

@ghost ghost closed this as completed Oct 18, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Drivers area: X86 x86 Architecture (32-bit) bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants