Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: length variable inconsistency in keys.c #18483

Closed
jhedberg opened this issue Aug 19, 2019 · 3 comments
Closed

Bluetooth: length variable inconsistency in keys.c #18483

jhedberg opened this issue Aug 19, 2019 · 3 comments
Assignees
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone

Comments

@jhedberg
Copy link
Member

After commit 94451b2 there's an inconsistency with length variable usage:

if (len_rd != BT_KEYS_STORAGE_LEN) {
BT_ERR("Invalid key length %zu != %zu", len,
BT_KEYS_STORAGE_LEN);

Is the if-statement wrong in using len_rd or is the log message wrong in using len?

@jhedberg jhedberg added bug The issue is a bug, or the PR is fixing a bug area: Bluetooth labels Aug 19, 2019
@aescolar
Copy link
Member

Unfortunately @fnde-ot is out for the next 2 weeks. But he had left this comment about this: 94451b2#r34438851

@aescolar
Copy link
Member

@jhedberg I bounce this issue back at you as we cannot expect @fnde-ot to react any time soon.

@ioannisg ioannisg added this to the v2.1.0 milestone Aug 20, 2019
@ioannisg ioannisg added the priority: low Low impact/importance bug label Aug 20, 2019
@dleach02 dleach02 modified the milestones: v2.1.0, v2.2.0 Dec 10, 2019
@aescolar
Copy link
Member

Fixed as a sideeffect of #19407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

5 participants