Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/pcie: pcie_get_mbar() should return a void * not u32_t #19550

Closed
ghost opened this issue Oct 2, 2019 · 3 comments
Closed

drivers/pcie: pcie_get_mbar() should return a void * not u32_t #19550

ghost opened this issue Oct 2, 2019 · 3 comments
Assignees
@andrewboie
Labels
area: Drivers bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@ghost
Copy link

ghost commented Oct 2, 2019

These bars are meant to be used for MMIO, so they should return void *.
@ghost ghost added bug The issue is a bug, or the PR is fixing a bug area: Drivers labels Oct 2, 2019
@ghost ghost self-assigned this Oct 2, 2019
@dleach02 dleach02 added the priority: low Low impact/importance bug label Oct 8, 2019
@ghost ghost closed this as completed Oct 18, 2019
@andrewboie andrewboie reopened this Jun 10, 2020
@andrewboie
Copy link
Contributor

Not sure why this was closed. This is an actual problem on 64-bit if an MMIO base address is returned that is greater than 4GB.

@andrewboie andrewboie added priority: medium Medium impact/importance bug and removed priority: low Low impact/importance bug labels Jun 10, 2020
@andrewboie
Copy link
Contributor

Suggest having this and related APIs return a uintptr_t since it is a physical address that will need to be mapped in the MMU.

@andrewboie
Copy link
Contributor

I don't remember who fixed this but it returns a uintptr_t now, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewboie andrewboie

Labels
area: Drivers bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewboie @dleach02